Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Aug 29, 2024

Proposed Changes

It was observed that rabbit_core_metrics_gc and rabbit_stream_metrics_gc processes can grow to several MBs of memory (probably because fetching the list of all queues). As they execute infrequently (every 2 minutes by default) it can save some memory to hibernate them in-between (similar to other similar processes).

On an idle test server with 30K queues the rabbit_core_metrics_gc process consumed ~50MB memory.

This is an ad-hoc optimisation (low-hanging fruit) mostly to follow good practice of hibernating similar processes.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments


This is an automatic backport of pull request #12149 done by [Mergify](https://mergify.com).
This is an automatic backport of pull request #12150 done by [Mergify](https://mergify.com).

It was observed that `rabbit_core_metrics_gc` and
`rabbit_stream_metrics_gc` processes can grow to several MBs of
memory (probably because fetching the list of all queues). As they
execute infrequently (every 2 minutes by default) it can save some
memory to hibernate them in-between (similar to other similar
processes).

(cherry picked from commit 065395e)
(cherry picked from commit ca4324c)
@michaelklishin michaelklishin added this to the 3.13.8 milestone Aug 29, 2024
@michaelklishin michaelklishin merged commit 5f4758a into v3.13.x Aug 29, 2024
@michaelklishin michaelklishin deleted the mergify/bp/v3.13.x/pr-12150 branch August 29, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants